Refactor Overview Utilization menu text

[GregP]

Refactor Utilization menu to be listed under Overview.

https://bugzilla.redhat.com/show_bug.cgi?id=1729136

Screen shot of Utilization menu prior to code fix:

Screen shot of Utilization menu listed under Overview main menu post code fix:

[miq-bot]

Checked commits GregP/manageiq@e3079f1~...159d256 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

[Fryguy]

👎 This does not belong in core ManageIQ as it is part of a CloudForms-only plugin.

If shortcuts are not pluggable they need to be made pluggable first.

[Fryguy]

This should be pulled out into a separate PR

[GregP]

@h-kataria @bdunne @Fryguy Removed the commit with Red Hat Cloud menus, will mark up and comment the BZ as well. And renamed the PR to reflect only changes to Utilization menu.

[GregP]

@Fryguy @bdunne @h-kataria This is similar to another recent change, with Migration menus. Which are also a gem, and those were handled inside the gem code. I think something similar should be done here as well. This is a 2 part PR, first commit should still apply. Second one, for the Red Hat Cloud menus, I can delete for now until we figure out where it belongs. And maybe add a comment to the BZ itself once we reach a decision.

[bdunne]

This is a 2 part PR, first commit should still apply.

I'm with @Fryguy , I don't really understand how the first commit is related to this PR

[GregP]

@Fryguy @bdunne Its the other way around. Start at Login drop down lists all the miq shortcust, and this is how the BZ started. Red Hat Cloud was a later on "add on" to the BZ. Main reason I am saying that Red Hat Cloud commit should be deleted from the above, and first commit, dealing with refactoring of Utilization menu and main point of the BZ, should stay. I can change PR name to not reference Red Hat Cloud.

[simaishi]

Ivanchuk backport details:

$ git log -1
commit c19e03774a708991f520945b8ebe4996ef9f3ce1
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Aug 1 15:18:24 2019 -0400

    Merge pull request #19062 from GregP/add_red_hat_cloud_menus
    
    Refactor Overview Utilization menu text
    
    (cherry picked from commit 499cb1489a2f12b5b6636e5fb024af99cce5d2eb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1729136