Allow MiqSchedule to accept nil and skip scheduling #19105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heduling instead of raising error Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1736749
yrudman
force-pushed
the
pass-nil-to-miq_scheduler-to-ignore-schedule
branch
from
246c6f3
to
f02afae
Compare
|
Checked commit yrudman@f02afae with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 7, 2019
…gnore-schedule Allow MiqSchedule to accept nil and skip scheduling (cherry picked from commit 52f7821) https://bugzilla.redhat.com/show_bug.cgi?id=1736749
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Oct 21, 2019
…gnore-schedule Allow MiqSchedule to accept nil and skip scheduling (cherry picked from commit 52f7821) https://bugzilla.redhat.com/show_bug.cgi?id=1763862
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: there is no good way to disable not needed schedule.
FIX: accept nil or empty string as first argument to
MiqScheduleWorker::Scheduler#schedule_everywhich will trigger skipping schedulingFixes https://bugzilla.redhat.com/show_bug.cgi?id=1736749
@miq-bot add-label enhancement, core, changelog/yes, hammer/yes, ivanchuk/yes
\cc @gtanzillo