Service display has been renamed to visible. #19211
Conversation
|
Maybe a silly question, but why not just define a custom |
| @@ -107,6 +108,7 @@ class Service < ApplicationRecord | |||
| alias parent_service parent | |||
| alias_attribute :service, :parent | |||
| virtual_belongs_to :service | |||
| deprecate_attribute :display, :visible | |||
There was a problem hiding this comment.
@lfu Does deprecate_attribute allow visible to be exposed through the Automate service model?
There was a problem hiding this comment.
deprecate_attribute calls virtual_attribute that would allow visible to be exposed to automate.
@djberg96 Thanks for the comment. But that won't work for automate method which is handled DRb. |
|
LGTM once the dependent PR is merged. |
To avoid name conflict with Kernel#display method. https://bugzilla.redhat.com/show_bug.cgi?id=1737559
The column was renamed on Service but not on ServiceTemplate
bdunne
force-pushed
the
rename_service_display_1737559
branch
from
6ac2699
to
781a3d5
Compare
|
Checked commits lfu/manageiq@9c72451~...781a3d5 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lfu Does the same change need to be applied to |
To avoid name conflict with Kernel#display method.
Depends on ManageIQ/manageiq-schema#410.
https://bugzilla.redhat.com/show_bug.cgi?id=1737559
@miq-bot assign @tinaafitz
@miq-bot add_label bug, ivanchuk/no, changelog/yes