A full translation in Chinese - Hong Kong #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManeraKai
reviewed
Oct 8, 2021
|
@CafeTango Thanks a lot 😉. @ManeraKai Will this variable |
|
Yes: |
ManeraKai
added a commit
that referenced
this pull request
Oct 8, 2021
|
Note: Flutter (the framework) requires a fallback Chinese language. Hong Kong is a subChinese language. I've created a duplicate for now of Honk Kong's subLanguage as a Main Chinese language. Is this a good practice or should I make it fall back to English @CafeTango? |
|
In my opinion, fall back to English is fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.