Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link statically to QuaZip #716

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Link statically to QuaZip #716

merged 4 commits into from
Nov 14, 2024

Conversation

ThomasKroes
Copy link
Contributor

@ThomasKroes ThomasKroes commented Nov 13, 2024 •
edited
Loading

  • Remove redundant ManiVault\cmake\CMakeQuaZipSymlink.cmake CMake utility file and references to this file
  • Remove redundant dependency on ZLib from the ManiVault/CMakeLists.txt core CMake file
  • Test on Windows
  • Test on MacOS
  • Test on Linux
  • Test on CI

@ThomasKroes
Link statically to QuaZip
c9448ef 
Remove redundant CMake utility file
Remove redundant dependency on ZLib from the core CMake file
@ThomasKroes ThomasKroes self-assigned this Nov 13, 2024
@ThomasKroes
Remove last reference to create_quazip_symlink CMake utility file
7792229
@ThomasKroes
Fix core CMake
72e9483 
Put back ZLib and link statically to it
Do not install QuaZip on MacOS
Install ZLib license
@ThomasKroes
Put ZLib before QuaZip in CMake
4b0fe93
@alxvth
Copy link
Contributor

alxvth commented Nov 13, 2024

Works on linux as well!

@alxvth
Copy link
Contributor

alxvth commented Nov 13, 2024

Note for future reference: Quazip is mainly distributed under LGPL but contains a STATIC LINKING EXCEPTION in their license that

"give[s] permission to link this library with independent modules to produce an executable and to copy and distribute the resulting executable under terms of your choice [...]"

@ThomasKroes ThomasKroes merged commit e5c40f7 into master Nov 14, 2024
8 checks passed
@ThomasKroes ThomasKroes deleted the feature/link_to_quazip_statically branch November 14, 2024 08:25
ThomasKroes added a commit that referenced this pull request Nov 26, 2024
@ThomasKroes
Link statically to QuaZip (#716)
4207957 
* Link statically to QuaZip

Remove redundant CMake utility file
Remove redundant dependency on ZLib from the core CMake file

* Remove last reference to create_quazip_symlink CMake utility file

* Fix core CMake

Put back ZLib and link statically to it
Do not install QuaZip on MacOS
Install ZLib license

* Put ZLib before QuaZip in CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxvth alxvth alxvth approved these changes

Assignees

@ThomasKroes ThomasKroes

Labels
core enhancement New feature or request Linux macOS Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasKroes @alxvth