Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tix toggle action drag and drop #723

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

ThomasKroes
Copy link
Contributor

Fixes

  • ToggleAction drag-and-drop does not corrupt the toggle state anymore
  • Remove virtual ... final constructions from the WidgetAction
  • Some other housekeeping

Enhancements

  • Move drag behavior to dedicated WidgetActionDrag class

Move action drag behavior to specific WidgetActionDrag class
Remove virtual + final from WidgetAction class
Override WidgetAction destructor
@ThomasKroes ThomasKroes added bug Something isn't working enhancement New feature or request labels Nov 20, 2024
@ThomasKroes ThomasKroes self-assigned this Nov 20, 2024
@ThomasKroes ThomasKroes linked an issue Nov 20, 2024 that may be closed by this pull request
@ThomasKroes ThomasKroes merged commit b1e70ec into master Nov 20, 2024
8 checks passed
@ThomasKroes ThomasKroes deleted the feature/fix_toggle_action_drag_and_drop branch November 20, 2024 10:49
@ThomasKroes ThomasKroes restored the feature/fix_toggle_action_drag_and_drop branch November 20, 2024 11:29
ThomasKroes added a commit that referenced this pull request Nov 26, 2024
* Refactor

Move action drag behavior to specific WidgetActionDrag class
Remove virtual + final from WidgetAction class
Override WidgetAction destructor

* Check for dragging inside the ToggleAction and some housekeeping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle action drag-and-drop toggles value during drag-and-drop
1 participant