Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous issues #9

Closed
leotrs opened this issue May 19, 2020 · 8 comments
Closed

Previous issues #9

leotrs opened this issue May 19, 2020 · 8 comments
Labels
good first issue Good for newcomers help wanted We would appreciate help on this issue/PR

Comments

@leotrs
Copy link
Contributor

leotrs commented May 19, 2020

There are a number of open issues on the original manim repo. A good way to determine a path moving forward for this community fork is to go over those issues and copy them here (the useful ones at least) so that they can be assigned to someone and we can do something about them.

This will also signal to end users that there is a lot of activity on this repository.

@leotrs leotrs added good first issue Good for newcomers help wanted We would appreciate help on this issue/PR labels May 19, 2020
@eulertour
Copy link
Member

The low hanging fruit here is a way to verify the manim install. Basically something to dry-run a Scene, ensure that the bare minimum to render successfully is actually installed, and give a helpful error like LaTeX/FFmpeg isn't installed, media directory isn't writable, etc.

@leotrs
Copy link
Contributor Author

leotrs commented May 19, 2020

@eulertour good suggestion, forked it into its own issue.

Please keep suggesting here old issues that should be copied into the manim-community repo.

@safinsingh
Copy link
Contributor

Possible PRs to look into:

@TonyCrane
Copy link
Contributor

Possible PRs to look into:

Also 3b1b#1071 This pr fixes some serious bugs of Text() and Code(), but the effect of some of the latter commits is not good. Can we keep only the part of the commits that fixed the bugs before?

@NavpreetDevpuri
Copy link
Contributor

Also 3b1b#1071 This pr fixes some serious bugs of Text() and Code(), but the effect of some of the latter commits is not good. Can we keep only the part of the commits that fixed the bugs before?

which commit's effect is not good ?

@TonyCrane
Copy link
Contributor

which commit's effect is not good ?

The last few are to resolve Transform's commits.
I don't think they are necessary, and they are more difficult to understand and not easy to use.

@NavpreetDevpuri
Copy link
Contributor

NavpreetDevpuri commented May 21, 2020

I think they are necessary because

  • Resolve Transformations. Without that Transformations seems ugly.
  • Open a ability to access chars differently as visible sub-mobjects.
  • Open abilities to new modifications something like Text.words and Text.lines. I will do that.
  • Add more functionalities to Text()

As you said "more difficult to understand" i want to ask you that what if Grant Sanderson thinks the same Did he able to make manim? there are so many things that seems difficult to understand.

Is using Text.chars or remove_invisible_chars() seems difficult ?

Without those modifications someone may post an issue saying "Hey this Text transformations is wrong".

@leotrs
Copy link
Contributor Author

leotrs commented May 21, 2020

Thanks everyone for bringing up all these previous issues. I think this issue has achieved the purpose of gathering all of these. So I'm going to ask the participants @NavpreetDevpuri @safinsingh @eulertour @tony031218 to feel free to take any of those issues you have listed and open them again here in this repo. We can come back to this list for future reference. But I'm closing this for now.

In particular, @tony031218 and @NavpreetDevpuri please continue your discussion in a new issue dedicated to 3b1b#1071 :)

@leotrs leotrs closed this as completed May 21, 2020
Aathish04 added a commit that referenced this issue Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted We would appreciate help on this issue/PR
Projects
None yet
Development

No branches or pull requests

5 participants