-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies for Python 3.10 #2376
Conversation
See https://python-poetry.org/docs/dependency-specification/#caret-requirements. |
I've also encountered problems with this, and I think I understand why the change is important, so I'll describe it here for the sake of completeness:
This means that with
Hope this helps. |
Ok, looks like Poetry is using a new installer. I've removed all other dependencies and added that installer. |
I think I've fixed your problem. But right now the installation of Manim fails for Python3.10. |
The build fails, because Lines 46 to 47 in 7c7bd2b
Changing these lines to On a related note: constraints with Line 35 in 7c7bd2b
gets changed to
where |
|
I'm getting old... |
Co-authored-by: Marcin Serwin <marcin.serwin0@protonmail.com>
Finally, thanks a lot @marcin-serwin! |
After resolving the merge conflict, will the PR be ready? |
What the hell happened to the history, did I screw this up? |
I fixed it by clicking a single button 😄 |
Which button? And thanks for killing the CI, I totally wasn't anxiously waiting for the result of whether I managed to finally clean up this dependency mess. Ahhhh ;) |
Update branch button which GitHub shows.
Sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview: What does this pull request change?
Changes a line in
pyproject.toml
topython = ">=3.7,<3.11"
from:
python = ^3.7
And then ran
poetry update
.Motivation and Explanation: Why and how do your changes improve the library?
I tried running manim on python 3.10 with poetry and noticed that it was only failing on the scipy install, particularly in that it was installing
scipy 1.63
, not the latest scipy, which has support and binary wheels for python 3.10. I first tried to change this by doingpython = ">=3.7"
But then got this error:
So i just specified that it must be less than python 3.11 and then ran
poetry update
and scipy was updated in the process. Then, I could successfully run a manim scene.Further Information and Comments
I'm not sure what the
^
symbol means, and spent a long time trying to figure out to no avail. I don't think it's particularly important, but I could be wrong.Reviewer Checklist