Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log execution time of scene rendering in the Manim Checkhealth command #3855

Merged
merged 3 commits into from
Jul 13, 2024

Conversation

chopan050
Copy link
Contributor

Easy review! Requested by @uwezi to see how much time a helpee's computer takes to render the example scene, to evaluate whether a particular scene is actually slow/unoptimized or it's just the computer.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works.

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind using timeit.timeit? It's better for benchmarking because it prevents the garbage collector from scheduling a run at a bad time.

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks :)

@behackl behackl enabled auto-merge (squash) July 13, 2024 16:16
@JasonGrace2282 JasonGrace2282 added the enhancement Additions and improvements in general label Jul 13, 2024
@behackl behackl merged commit 3a71411 into ManimCommunity:main Jul 13, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants