Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pls add GcCellRef::filter_map like in std::cell::Ref::filter_map #176

Closed
minus1ms opened this issue Jul 17, 2024 · 3 comments · Fixed by #177
Closed

pls add GcCellRef::filter_map like in std::cell::Ref::filter_map #176

minus1ms opened this issue Jul 17, 2024 · 3 comments · Fixed by #177

Comments

@minus1ms
Copy link

pls add GcCellRef::filter_map like in std::cell::Ref::filter_map
i really need it for my project, it can be added quickly i guess, i could fork it too but maybe it will be added fast
@Manishearth
Copy link
Owner

It's not clear to me if this can be done safely? Probably, but it needs some thought.

At the very least if you're in a rush for this please provide a PR.

andersk added a commit to andersk/rust-gc that referenced this issue Jul 17, 2024
@andersk
Add GcCellRef::filter_map
5d43f72 
Fixes Manishearth#176.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk mentioned this issue Jul 17, 2024
Merged
andersk added a commit to andersk/rust-gc that referenced this issue Jul 17, 2024
@andersk
Add GcCellRef::filter_map
2224e16 
Fixes Manishearth#176.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@Manishearth
Copy link
Owner

Anders put up a PR in #177 !

@minus1ms
Copy link
Author

thx a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GcCellRef::filter_map, GcCellRefMut::filter_map andersk/rust-gc
2 participants
@Manishearth @minus1ms