Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cgc<T> - a concurrent threadsafe garbage collector #6

Closed
wants to merge 9 commits into from

Conversation

mystor
Copy link
Collaborator

@mystor mystor commented Jun 1, 2015

Don't merge this yet - this is a work in progress PR for us to talk about the implementation and potential problems with it.

This update to the Trace trait should make it easier to implement the concurrent
garbage collector in parallel to the current threadlocal garbage collector.

Unfortunately, it also causes object safety problems due to the type parameter in the
_trace method. Further investigation should be done to see if this can be fixed.
@Manishearth
Copy link
Owner

Is this merge-ready? 😄

GC in Rust seems to be waking up again.

@mystor
Copy link
Collaborator Author

mystor commented Aug 26, 2015

@Manishearth IIRC the biggest problem with it was that it wasn't very well tested... Not sure about any other problems...

@Manishearth
Copy link
Owner

We should probably ask the community to poke this crate a bit more

@mystor
Copy link
Collaborator Author

mystor commented Aug 26, 2015

No kidding ^.^ - we should also test it manually a bunch more too.

I'd honestly probably feel the most comfortable with letting the concurrent collector bitrot a bit, and focusing on the threadlocal one. It seems the least likely to have any serious problems.

(Also I think I remember there was some problem with CGCs inside of Gcs or something like that)

@torkleyy
Copy link

Wouldn't it be more consistent to call it Agc (like Arc and Rc)? And will there be a merge because this PR was created more than half a year ago? @mystor @Manishearth

@TyOverby
Copy link
Contributor

@torkleyy : this Gc isn't atomic, it's concurrent, so Agc would be misleading.

@damienmg
Copy link

Is it staled or still a work in progress?

@mystor mystor closed this Sep 18, 2018
@mystor
Copy link
Collaborator Author

mystor commented Sep 18, 2018

This isn't going to happen any time soon. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants