Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential performance issue: .apply slow in pandas 1.4.0 #72

Open
TendouArisu opened this issue Mar 1, 2024 · 1 comment
Open

Potential performance issue: .apply slow in pandas 1.4.0 #72

TendouArisu opened this issue Mar 1, 2024 · 1 comment

Comments

@TendouArisu
Copy link

Issue Description:

Hello.
I have discovered a performance degradation in the .apply function of pandas version below 1.5. And I notice the repository depends on pandas 1.4.0 requirements.txt. I am not sure whether this performance problem in pandas will affect this repository. I found some discussions on pandas GitHub related to this issue, including #44172 and #45404.
I also found that alphamap/preprocessing.py and alphamap/importing.py used the influenced api. There may be more files using the influenced api and more parts using pandas 1.4.0.

Suggestion

I would recommend considering an upgrade to a different version of pandas >= 1.5 or exploring other solutions to optimize the performance of .apply.
Any other workarounds or solutions would be greatly appreciated.
Thank you!

@ibludau
Copy link
Collaborator

ibludau commented Jul 25, 2024

Hi - thanks a lot for your comment and sorry for the long silence. we just created a new release which uses loose dependencies. could you please check if your performance issue still persists and let us know. thanks a lot - I hope we can improve your alphamap experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants