Skip to content

Commit

Permalink
replace throw-error with error-log to avoid UAF mentioned in ros-navi…
Browse files Browse the repository at this point in the history
…gation#4175 (ros-navigation#4180)

* replace throw-error with error-log to avoid UAF

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

* fix typo

Signed-off-by: GoesM <GoesM@buaa.edu.cn>

---------

Signed-off-by: GoesM <GoesM@buaa.edu.cn>
Co-authored-by: GoesM <GoesM@buaa.edu.cn>
  • Loading branch information
2 people authored and Manos-G committed Aug 1, 2024
1 parent f10596d commit b86a8ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nav2_util/include/nav2_util/simple_action_server.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ class SimpleActionServer
if (steady_clock::now() - start_time >= server_timeout_) {
terminate_all();
if (completion_callback_) {completion_callback_();}
throw std::runtime_error("Action callback is still running and missed deadline to stop");
error_msg("Action callback is still running and missed deadline to stop");
}
}

Expand Down

0 comments on commit b86a8ed

Please sign in to comment.