-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Calamari]Bump deps to polkadot-v0.9.11 #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the CHANGELOG.md
file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the 2 statemint commits you used to get their diff.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should either keep or remove try-runtime
feature entirely.
Done. |
LGTM |
Description
closes: #210
Deps Changes
Polkadot Changes:
force_unfreeze
extrinsic to the disputes module paritytech/polkadot#3906Substrate Changes:
Cumulus Changes:
statemine diffs between:
fa116cfbfb470a8114fc02f9d2e3c0a5ab6c7193 -> 0.9.10
ede4d527c4fc5d84c43216b408a873625488574b-> 0.9.11
Our Changes
Client
3.0.5
to3.0.6
.fn rpc_http_threads
andtelemetry_external_transport
fromRelayChainCli
: changenative_executor_instance
, we have to manually implement it: changeRuntime
New associated type
OperationalFeeMultiplier
forpallet_transaction_payment
: changeThis means A fee mulitplier for
Operational
extrinsics to compute "virtual tip" to boost theirpriority
.See more details from here: OperationalFeeMultiplier
I think 5 should be fine.
New associated types
AssetTrap
andAssetClaims
. This is for xcm configuration. For now, we don't enable xcm in calamari, we can just follow statemint' configuration, it should be fine.More details: associated types
Update configuration for
pallet_xcm
. Just follow statemint' configuration.More details: https://github.com/Manta-Network/Manta/blob/jamie/upgrade-deps-v0.9.11/runtime/calamari/src/lib.rs#L405
New associated type
MaxAuthorities
forpallet_aura
.This means The maximum number of authorities that the pallet can hold.
Now, we don't allow comunity to run collator, we can consider it later.
More details: https://github.com/paritytech/substrate/blob/polkadot-v0.9.11/frame/aura/src/lib.rs#L75
Bump
spec_version
to 2.Tests
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ormanta-pc
) with right title (start with [Manta] or [Manta-PC]),Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated