Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hook up story-pins editor to playback #135

Closed
ischneider opened this issue Jan 30, 2015 · 2 comments
Closed

hook up story-pins editor to playback #135

ischneider opened this issue Jan 30, 2015 · 2 comments
Assignees
@ischneider

Comments

@ischneider
Copy link
Member

Based on our 'protocol', this means:

  • set timeAttribute property on layer
  • use features property on layer to store annotations

See also #134
@bartvde
Copy link
Member

bartvde commented Feb 2, 2015

The disadvantage here of using the same approach is that we'll need to keep the features param in sync. For normal vector layers this is no issue since we load all features upon first load. But maybe this is no big deal.

@ischneider ischneider self-assigned this Feb 2, 2015
ischneider added a commit that referenced this issue Feb 10, 2015
@ischneider
storypins edit and playback work, refs #135
0ad37ef 
- local storage service for persistence
- add/edit/delete working
- playback and timeline
- many tests added
- start/end date in filtering, refs #136
- listen for layer changes and compute time, refs #134
@ischneider
Copy link
Member Author

Added as part of 0ad37ef, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ischneider ischneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartvde @ischneider