Popup keyboard navigation bug when dismissing popup #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed and maybe it's a different bug or perhaps a regression, that when you use the arrow keys to "tab" into a set of features, then you popup a dialog and dismiss it, either with esc or X, if you hit "Tab" then you don't move past the features, you move to the next feature. That tab should take you to the zoom out button, shouldn't it? Try it on experiments, although because of this bug it's hard to say if it's a part of this bug or another bug?? Edit: I can't reproduce this maybe I was mistaken |
AliyanH
reviewed
Jan 27, 2023
prushforth
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #681