Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privatize global M. Methods which were not intended to become global #734

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Privatize global M. Methods which were not intended to become global #734

merged 5 commits into from
Feb 14, 2023

Conversation

AliyanH
Copy link
Member

@AliyanH AliyanH commented Jan 30, 2023 •
edited
Loading

Added documentation for all Utils, and privatized the following util methods:

  • M.handleLink -> M._handleLink
  • M.convertAndFormatPCRS -> M._convertAndFormatPCRS
  • M.parseNumber -> M._parseNumber
  • M.extractInputBounds -> M._extractInputBounds
  • M.splitCoordinate -> M._splitCoordinate
  • M.metaContentToObject -> M._metaContentToObject
  • M.coordsToArray -> M._coordsToArray
  • M.parseStylesheetAsHTML -> M._parseStylesheetAsHTML
  • M.gcrsToTileMatrix -> M._gcrsToTileMatrix

closes #717

@AliyanH
Copy link
Member Author

AliyanH commented Jan 30, 2023

@prushforth Please give your suggestions on whether any methods needs to be made private/public. Thanks.

@AliyanH
Copy link
Member Author

AliyanH commented Feb 14, 2023

Merging this, can privatize more methods in the future as needed.

@AliyanH AliyanH merged commit 5f3c25d into Maps4HTML:main Feb 14, 2023
@AliyanH AliyanH deleted the private branch February 14, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prushforth prushforth Awaiting requested review from prushforth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Privatize global M. Methods which were not intended to become global
1 participant
@AliyanH