Reorganize the copy/paste menu #743

yhy0217 · 2023-02-06T19:15:57Z

Closes #698

redesign/simplify the copy/paste menu
delete "copy layer extent" in layer context menu
modify codes to support copying current extent
modify existing tests and add new test for copy menu
fix bug that esc key does not dismiss the menu when focus is on "Copy (C)" closes Esc Key does not work when focused on map context menu item: "Copy Coordinates (C)" #746
modify styling to fit the new design of menu

src/mapml/handlers/ContextMenu.js

src/mapml/options.js

src/mapml/handlers/ContextMenu.js

add a test in mapContextMenu.test.js stop layermenu and contextmenu from showing up at the same time reorganize copy menu and modify tests modify tests to cope with the disabled back/forward btn extend wait time in tests remove querySelector, use this add locales for copying mapml/ext/loc Reverse erroneous conflict resolutions during rebase

test/e2e/mapml-viewer/viewerContextMenu.test.js

yhy0217 requested review from prushforth and AliyanH February 6, 2023 19:15

This comment was marked as resolved.

Sign in to view

AliyanH reviewed Feb 7, 2023

View reviewed changes

src/mapml/handlers/ContextMenu.js Outdated Show resolved Hide resolved

AliyanH reviewed Feb 7, 2023

View reviewed changes

src/mapml/options.js Outdated Show resolved Hide resolved

AliyanH reviewed Feb 7, 2023

View reviewed changes

src/mapml/handlers/ContextMenu.js Outdated Show resolved Hide resolved

yhy0217 marked this pull request as ready for review February 7, 2023 18:48

prushforth force-pushed the reorganizeMenu branch from 3f0f99c to dd33e8d Compare February 7, 2023 22:52

prushforth added 2 commits February 7, 2023 20:51

Reorganize context menu - tests will break

41eca0f

Fix tests, still a few to fix

81a4a04

prushforth reviewed Feb 8, 2023

View reviewed changes

test/e2e/mapml-viewer/viewerContextMenu.test.js Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

yhy0217 added 4 commits February 8, 2023 11:58

modify tests and menu styling things

8611ae8

format codes

7d54ee9

truncate PCRS values to integers

e4e2b0c

do rounding instead of truncation

308ca9e

yhy0217 merged commit 2b8e60e into Maps4HTML:main Feb 13, 2023

yhy0217 deleted the reorganizeMenu branch February 14, 2023 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize the copy/paste menu #743

Reorganize the copy/paste menu #743

yhy0217 commented Feb 6, 2023 •

edited by AliyanH

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Reorganize the copy/paste menu #743

Reorganize the copy/paste menu #743

Conversation

yhy0217 commented Feb 6, 2023 • edited by AliyanH Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

yhy0217 commented Feb 6, 2023 •

edited by AliyanH

Loading