Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place templated image layer at at (0,0) of CS when add it to map #761

Merged
merged 7 commits into from
Feb 24, 2023
Merged

Place templated image layer at at (0,0) of CS when add it to map #761

merged 7 commits into from
Feb 24, 2023

Conversation

yhy0217
Copy link
Contributor

@yhy0217 yhy0217 commented Feb 17, 2023 •
edited
Loading

Closes #759

  • fix bug that the templated image layer is misplaced when it is re-added to map
  • fix bug that the templated image layer is duplicated when zooming in/out
  • add a test

@prushforth
Copy link
Member

@yhy0217 I don't know if it's the same bug, but this page really demonstrates templated image misplacement

@yhy0217 yhy0217 marked this pull request as ready for review February 23, 2023 19:23
@prushforth
Copy link
Member

LGTM

@prushforth prushforth merged commit 0e006d2 into Maps4HTML:main Feb 24, 2023
@yhy0217 yhy0217 deleted the issue759 branch February 24, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliyanH AliyanH AliyanH left review comments

@prushforth prushforth prushforth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Templated image layer doesn't show at right place when turning it off then on
3 participants
@yhy0217 @prushforth @AliyanH