Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce zoom #772

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Announce zoom #772

merged 3 commits into from
Mar 7, 2023

Conversation

kevinkim31
Copy link
Contributor

@kevinkim31 kevinkim31 commented Feb 28, 2023

closes #664

  • Update Web-Map-Custom-Element to audibly render zoom in output by default i.e. on by default
  • Update MapML-Extension to reflect the fact that the option to audibly render zoom is on by default, provide option to turn it off. "Announce movement for screen readers" -> "Announce Zoom"
  • Update Web-Map-Doc.
  • Change the name of this experiment. We should add the pan/zoom control to that map, as well as a <map-caption>Paris, the City of Light</map-caption>

@kevinkim31 kevinkim31 marked this pull request as ready for review March 1, 2023 14:14
@prushforth prushforth requested a review from Malvoz March 2, 2023 16:01
@prushforth
Copy link
Member

prushforth commented Mar 2, 2023

@Malvoz no rush but if you could have a listen etc to this, please. I find that announce movement may not be too useful in its current form, but announce zoom might be a bit more useful as an update to that functionality. I had the notion that it would be cool to calculate an approximate scale ratio for the (centre of the) current map view and announce that, e.g. "One centimetre to 47 metres" etc. I guess we would have to add a visual scale bar control too if we did that, but the zoom levels themselves aren't too relatable to anyone just yet, similar to actual coordinates of any kind (that's computer language, not human language).

@prushforth
Copy link
Member

See checklist

src/mapml/handlers/AnnounceMovement.js Outdated Show resolved Hide resolved
src/mapml/handlers/AnnounceMovement.js Outdated Show resolved Hide resolved
src/mapml/handlers/AnnounceMovement.js Outdated Show resolved Hide resolved
@prushforth prushforth merged commit 2782aeb into Maps4HTML:main Mar 7, 2023
@prushforth
Copy link
Member

Merging to keep the process going; feel free to comment when possible. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Announce zoom
2 participants