Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dynamic scale bar and announce a scale ratio for each map view for screen readers #794

Merged
merged 59 commits into from
Apr 6, 2023
Merged

Add a dynamic scale bar and announce a scale ratio for each map view for screen readers #794

merged 59 commits into from
Apr 6, 2023

Conversation

kevinkim31
Copy link
Contributor

closes #777

@prushforth
Copy link
Member

prushforth commented Mar 13, 2023 •
edited
Loading

Haven't listened to it yet, but looks nice. I think you'll have to adjust the space between the scalebar and the bottom of the map, up a bit, because on maps that display links, the links draw over top of the scalebar. Note that the scale ratios look incorrect when zooming on the linked map.

@kevinkim31
Copy link
Contributor Author

initial announce template

Not ready for review just yet. Still need to work on the announcing but should be done soon.

AliyanH
AliyanH reviewed Mar 20, 2023
View reviewed changes
src/mapml-viewer.js Outdated Show resolved Hide resolved
prushforth
prushforth reviewed Mar 30, 2023
View reviewed changes
src/mapml-viewer.js Outdated Show resolved Hide resolved
prushforth
prushforth reviewed Mar 30, 2023
View reviewed changes
src/web-map.js Outdated Show resolved Hide resolved
kevinkim31 and others added 29 commits April 6, 2023 12:22
@kevinkim31 @prushforth
some changes ; needs fixing up
21de21f
@kevinkim31 @prushforth
changes for announce
cc868bc
@kevinkim31 @prushforth
slight modifications
1caa716
@kevinkim31 @prushforth
parsefloat to prevent .0 from being read out
73a2d97
@kevinkim31 @prushforth
read on load
bd64364
@kevinkim31 @prushforth
web-map
c54aab7
@kevinkim31 @prushforth
fix and add testing
5f8e377
@kevinkim31 @prushforth
move scalebar down a bit
8956324
@kevinkim31 @prushforth
problem with tabbing back in
8579fef
@kevinkim31 @prushforth
add tab indexing
9572b0a
@kevinkim31 @prushforth
fix testing
d5f00e1
@kevinkim31 @prushforth
clean up code
269104b
@kevinkim31 @prushforth
implement changes
00e379a
@prushforth
Rename AnnounceMovement handler to PanZoom / meaningfulPanZoom handler
864fbca
@prushforth
Revert "Rename AnnounceMovement handler to PanZoom / meaningfulPanZoo…
b6561e6 
…m handler"

This reverts commit c557804.
@kevinkim31 @prushforth
integrate both scales to one
509bf84
@prushforth
Remove _container member property.
7c642df
@prushforth
Make scalebar control creation conditional, similar to other controls
8c0344c
@kevinkim31 @prushforth
fix styling
2875999
@kevinkim31 @prushforth
fix styling
66ec9cf
@kevinkim31 @prushforth
fix styling
3df5442
@kevinkim31 @prushforth
fix styling
762bc5e
@AliyanH
set scalebar position based on initial map size
357e623
@prushforth
Fix some stuff broken during conflict resolution
99b02cd
@prushforth
Merge branch 'map-scalebar' of https://github.com/kevinkim31/Web-Map-…
b4fd653 
…Custom-Element into map-scalebar
@prushforth
Account for scalebar control in location control tests (need extra tab)
5bc3032 
Fix lint errors
@kevinkim31
final changes
1aab4bb
@kevinkim31
final changes
41f2334
@kevinkim31
final changes
247aec2
@kevinkim31 kevinkim31 merged commit 2b0342b into Maps4HTML:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prushforth prushforth prushforth approved these changes

@AliyanH AliyanH Awaiting requested review from AliyanH

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a dynamic scale bar and announce a scale ratio for each map view for screen readers
3 participants
@kevinkim31 @prushforth @AliyanH