Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy layer with relative path fails when pasted layer does not have the same base path #824

Merged
merged 9 commits into from
Apr 26, 2023

Conversation

kevinkim31
Copy link
Contributor

closes #817

src/layer.js Outdated Show resolved Hide resolved
src/layer.js Outdated Show resolved Hide resolved
test/e2e/core/layerContextMenu.html Outdated Show resolved Hide resolved
src/layer.js Outdated Show resolved Hide resolved
Copy link
Member

@AliyanH AliyanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/layer.js Outdated Show resolved Hide resolved
test/e2e/core/layerContextMenu.test.js Show resolved Hide resolved
@prushforth

This comment was marked as resolved.

@prushforth
Copy link
Member

When I copy an unchecked Restaurants layer from here, and paste it onto the map here, it is intially checked but not displayed. I believe it should not be checked. This is a bug in some other code tbd, not a concern here, as the tref in the underlying map-extent is correctly resolved.

@prushforth
Copy link
Member

LGTM

@kevinkim31 kevinkim31 merged commit 92ccc41 into Maps4HTML:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy layer with relative path fails when pasted layer does not have the same base path
3 participants