Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow keys to navigate contextmenu #830

Merged
merged 12 commits into from
Apr 28, 2023
Merged

Conversation

Jacky0299
Copy link
Contributor

No description provided.

AliyanH

This comment was marked as resolved.

@prushforth
Copy link
Member

@Malvoz we have an a11y issue we need an expert opinion on: Can we neglect use of tab keys to navigate the context menu? Chrome context menu itself does not seem to respond to tab keys, but maybe we have got the "button" semantic in place so we need to maintain tab key support. WDYT?

@prushforth
Copy link
Member

Small visual difference noted when you pull out the Copy > submenu, it puts a focus ring on the first item; generally the focus ring is only shown when using keyboard.

image

Unlike the hover behaviour, the focus ring doesn't move when you move your pointer, so I believe the focus ring should not be shown in this case (when using the pointer only):
image
image

@prushforth
Copy link
Member

Awesome work Jacky 👍👏

@Jacky0299 Jacky0299 merged commit 1e2fce8 into Maps4HTML:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants