Add map-projectionchange event. #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from triggering map-change event. Allow map-extent to react to map-projectionchange event, enable/disable according to projection match. Change initialization logic for opacity, so that layer- and map-extent opacity value is maintained through map-projectionchange event. Remove MapMLLayer.validProjection attribute and flawed logic. Prettier formatting change only in multipleExtents.test.js Remove use of validProjection by layer context menu, was wrong anyway(?) Add waitfortimeout of 500ms in customTCRS.test.js (100ms was not enough) Add test for simple projection change.
prushforth
force-pushed
the
map-projectionchange
branch
from
a7dd729
to
809ab3a
Compare
updating in time. Skip test of history after map-projectionchange, pending full rewrite of history api tbd.
11 tasks
so that invalid / undefined projections e.g. 'foo' will throw. Prettier formatting...
yhy0217
approved these changes
Nov 15, 2023
AliyanH
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #910
Fix history after map-projectionchangenot possible need to rewrite historymapml-viewer.defineCustomProjection