Add pmtiles support / dependency #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prushforth
force-pushed
the
pmtiles
branch
2 times, most recently
from
1e84137
to
47d4d01
Compare
|
@AliyanH I think we should try to cue up simultaneous PRs against web-map-doc and experiments repos, potentially write a short blog post on the CG home page for publishing when they land. |
Add TemplatedPMTilesLayer, update map-link to use it.
Add the application/vnd.mapbox-vector-tile media type to map-link,
which is the signal to pass {z}/{x}/{y}.mvt templates to TemplatedPMTilesLayer
Import symbolizer and other symbols explicitly from protomapsL
Update src/mapml/index.js to import from protomaps-leaflet module
directly.
Add grunt-rollup plugin-node-resolve to help bundle output esm from
protomaps
Add dynamic import of "pmtilesRules.js" module, containing user styles
for pmtiles / mvt layers via
<map-link rel=stylesheet type=application/pmtiles+stylesheet>
Use protomaps-leaflet v 4.0.0
Add protomapsL as M.protomapsL
Add label rule with filter example for Spearfish to pmtilesRules.js
Move example pmtilesRules.js into src, dist
Add image comparison test for local pmtiles mvt source, win32 png files
Add linux images for templatedPMTilesMVTLayer.test.js
Replace linux image that was missing glyphs or something
Comment out flaky image comparison (IIRC label selection is based on
tile load order, so not reliable for a test, probably)
Let images of labelled maps be up to 1500 pixels different, since labels
can move around based on tile loading order, and the fonts on different
systems are / can be different.
Update test to accommodate change to use of noWrap: true option
Update image for PMTiles test comparison on linux, in light of change to
using noWrap: true for M.protomapsL.leafletLayer option
Change names of URL template variables in test so that it tests the
ability to use non-hardcoded variable names.
Merge upstream/main renaming of principal repo
Add spearfish.pmtiles data file to test infrastructure
Add test dependency on serve-static so that test server supports byte
range request, a requirement of protomaps-leaflet
Test rendering of pmtiles and mvt data sources using light and dark
themes built into protomaps-leaflet (may break with changes to those
themes, tbd)
Change API for pmtilesRules.js - eliminate need to have single file and
hardcoded file name:
use <map-link rel=stylesheet type=application/pmtiles+stylesheet href="URL to pmtilesRules module">
with ability to include above <map-link> for each <map-extent> or <layer->
as required.
Change playwright.config.js to match current playwright documentation.
REMOVE setup.js, which was used by jest, no longer required.
- update/add pmtiles / mvt tests
- remove hard-coded name for pmtilesStyles.js filename is up to user
- add blank map image test image
- log errors to console, used in test assertions (these messages may
be helpful tbd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates protomaps-leaflet into mapml.js via rollup.
A user's style module should export the pmtilesRules object per the example in pmtilesStyles.js