-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malvoz attribution control #815
Merged
prushforth
merged 16 commits into
Maps4HTML:main
from
prushforth:malvoz-attribution-control
Apr 17, 2023
Merged
Malvoz attribution control #815
prushforth
merged 16 commits into
Maps4HTML:main
from
prushforth:malvoz-attribution-control
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliyanH
reviewed
Apr 14, 2023
…forth/Web-Map-Custom-Element into malvoz-attribution-control
prushforth
commented
Apr 14, 2023
This was referenced Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Jacky0299 see if you can get the tests running. I think I got all the relevant changes reconciled with main, tbd. I think we'll want to delete one of the attribution controls once we get this working and tested.
These commits were copied from this PR, hopefully faithfully, tbd.