Static Adapt methods now work as extension methods and fixed docs where 'OfType' should be 'ForType'. Also shows Enum -> string failure on compile with Explicit on. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-swann-q2
changed the title
eric-swann-q2
changed the title
…ile (enum) -> string fails
eric-swann-q2
changed the title
| @@ -312,6 +312,9 @@ internal TypeAdapterSettings GetMergedSettings(Type sourceType, Type destination | |||
| { | |||
| if (this.RequireExplicitMapping && mapType != MapType.InlineMap && !MapContext.HasContext) | |||
| { | |||
| if(sourceType.) | |||
There was a problem hiding this comment.
I guess you did not intend to add this line. This PR is cool except this line, please remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Adapt static methods to be extension methods on the source so the less terse notation can be used: var dto = product.Adapt(config);
Added a few tests for this and also fixed a problem in the documentation: 'OfType' should have been 'ForType' when using instance configuration.