fix(ios): reuse apple test bundle identifier #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malinskiy
commented
Feb 16, 2023
| @@ -34,6 +34,8 @@ val AppleVendor = module { | |||
| } | |||
| single<TestParser?> { AppleTestParser(get(), get(), get()) } | |||
| single<MarathonLogConfigurator> { AppleLogConfigurator(get()) } | |||
| single<TestBundleIdentifier?> { AppleTestBundleIdentifier() } | |||
| single<AppleTestBundleIdentifier> { AppleTestBundleIdentifier() } | |||
There was a problem hiding this comment.
This mistakenly created 2 bundle identifiers and hence produced "no test bundle identifier" errors in runtime
Codecov Report
@@ Coverage Diff @@
## develop #755 +/- ##
==========================================
Coverage 59.06% 59.06%
Complexity 832 832
==========================================
Files 210 210
Lines 4241 4241
Branches 669 669
==========================================
Hits 2505 2505
Misses 1407 1407
Partials 329 329 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.