Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC for v1.0.0 #101

Merged
merged 2 commits into from
Oct 21, 2022
Merged

RC for v1.0.0 #101

merged 2 commits into from
Oct 21, 2022

Conversation

MarcBerliner
Copy link
Owner

Added new operating modes for:

  • Temperature rate of change: dT
  • Plating overpotential at the separator-anode interface: η_p
  • max/min concentration rates of change in the solid electrodes and electrolyte: dc_s_p_max, dc_s_p_min, dc_s_n_max, dc_s_n_min, dc_e_max, dc_e_min
  • Any generic residual as a function of the states, times, and parameters: res

Fixed an error where the side reaction j_s was specified slightly incorrectly (thanks to Gerrit Ipers for pointing out this error)

Stop conditions now check for the derivative of the state or output to terminate the simulation

Added the option for custom stop conditions

Modifying the states and model outputs is now significantly easier, only requiring changes in states_definitions.jl, residuals.jl, and auxiliary_states_and_coefficients.jl

Bug fixes

@MarcBerliner MarcBerliner merged commit 05ea156 into master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant