Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in RateLimitAspect fallbackMethod checking #353

Closed
amarocco opened this issue Oct 25, 2024 · 0 comments
Closed

Improvement in RateLimitAspect fallbackMethod checking #353

amarocco opened this issue Oct 25, 2024 · 0 comments
Milestone

Comments

@amarocco
Copy link
Contributor

Looking to fix another issue with meta-annotation see I look at hte code of RateLimitAspect and saw that for checking if a fallbackMethod is setup currently we check if the annotation field is null rateLimitAnnotation.fallbackMethodName() but default value is empty "" we should probably check for notblank or notempty I will create a PR with the change

amarocco added a commit to amarocco/bucket4j-spring-boot-starter that referenced this issue Oct 25, 2024
@MarcGiffing MarcGiffing added this to the 0.12.8 milestone Oct 25, 2024
MarcGiffing added a commit that referenced this issue Nov 6, 2024
Co-authored-by: MarcGiffing <MarcGiffing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants