overload vim-addons directory path #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple change allows to specify vim-addons directory in .vimrc instead of hardcoding it in the function itself. This is especially useful if the user wants to tar-ball whole $HOME/.vim directory as a single config without including all of the third-party repositories that will checkout from repositories in new environment any way.
|
I feel this pull request is adding more bloat than value. The code you're changing is sample code every user ought to adjust to his liking anyway. It doesn't make much sense to get a value from the dictionary which the sample code doesn't set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to specify vim-addons directory in .vimrc instead of hardcoding it in the function itself; especially useful for users who tar-ball whole $HOME/.vim directory as their config without including all of the third-party add-ons that will checkout from repositories in new environment any way