Adform adapter supports string type sizes (prebid#2692)

* Allow to compare strings too. * Fixed lint errors
Marfeel · Sep 6, 2018 · 5b4e34d · 5b4e34d
1 parent e92473d
commit 5b4e34d
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 16 deletions.
diff --git a/modules/adformBidAdapter.js b/modules/adformBidAdapter.js
@@ -114,13 +114,12 @@ export const spec = {
         bidRespones.push(bidObject);
       }
     }
-
     return bidRespones;
 
     function verifySize(adItem, validSizes) {
       for (var j = 0, k = validSizes.length; j < k; j++) {
-        if (adItem.width === validSizes[j][0] &&
-            adItem.height === validSizes[j][1]) {
+        if (adItem.width == validSizes[j][0] &&
+            adItem.height == validSizes[j][1]) {
           return true;
         }
       }

diff --git a/test/spec/modules/adformBidAdapter_spec.js b/test/spec/modules/adformBidAdapter_spec.js
@@ -153,19 +153,6 @@ describe('Adform adapter', () => {
       let result = spec.interpretResponse({ body: {} }, {});
       assert.deepEqual(result, []);
     });
-    it('should respond with empty response when sizes doesn\'t match', () => {
-      serverResponse.body[0].response = 'banner';
-      serverResponse.body[0].width = 100;
-      serverResponse.body[0].height = 150;
-
-      serverResponse.body = [serverResponse.body[0]];
-      bidRequest.bids = [bidRequest.bids[0]];
-      let result = spec.interpretResponse(serverResponse, bidRequest);
-
-      assert.equal(serverResponse.body.length, 1);
-      assert.equal(serverResponse.body[0].response, 'banner');
-      assert.deepEqual(result, []);
-    });
     it('should respond with empty response when response from server is not banner', () => {
       serverResponse.body[0].response = 'not banner';
       serverResponse.body = [serverResponse.body[0]];
@@ -250,6 +237,51 @@ describe('Adform adapter', () => {
         assert.ok(!result[i].gdpr);
         assert.ok(!result[i].gdpr_consent);
       };
+    });
+
+    describe('verifySizes', () => {
+      it('should respond with empty response when sizes doesn\'t match', () => {
+        serverResponse.body[0].response = 'banner';
+        serverResponse.body[0].width = 100;
+        serverResponse.body[0].height = 150;
+
+        serverResponse.body = [serverResponse.body[0]];
+        bidRequest.bids = [bidRequest.bids[0]];
+        let result = spec.interpretResponse(serverResponse, bidRequest);
+
+        assert.equal(serverResponse.body.length, 1);
+        assert.equal(serverResponse.body[0].response, 'banner');
+        assert.deepEqual(result, []);
+      });
+      it('should respond with empty response when sizes as a strings doesn\'t match', () => {
+        serverResponse.body[0].response = 'banner';
+        serverResponse.body[0].width = 100;
+        serverResponse.body[0].height = 150;
+
+        serverResponse.body = [serverResponse.body[0]];
+        bidRequest.bids = [bidRequest.bids[0]];
+
+        bidRequest.bids[0].sizes = [['101', '150']];
+        let result = spec.interpretResponse(serverResponse, bidRequest);
+
+        assert.equal(serverResponse.body.length, 1);
+        assert.equal(serverResponse.body[0].response, 'banner');
+        assert.deepEqual(result, []);
+      });
+      it('should support size dimensions as a strings', () => {
+        serverResponse.body[0].response = 'banner';
+        serverResponse.body[0].width = 300;
+        serverResponse.body[0].height = 600;
+
+        serverResponse.body = [serverResponse.body[0]];
+        bidRequest.bids = [bidRequest.bids[0]];
+
+        bidRequest.bids[0].sizes = [['300', '250'], ['250', '300'], ['300', '600'], ['600', '300']]
+        let result = spec.interpretResponse(serverResponse, bidRequest);
+
+        assert.equal(result[0].width, 300);
+        assert.equal(result[0].height, 600);
+      });
     })
   });