Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid video pre mvp #47

Open
wants to merge 1,024 commits into
base: master
Choose a base branch
from
Open

Prebid video pre mvp #47

wants to merge 1,024 commits into from

Conversation

pedrolopezmrf
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

VideoReach and others added 30 commits August 6, 2019 12:10
* assign adapter version

* Mapped video parameter from prebid.js to cdb

* Mapped video parameter from prebid.js to cdb

* Ensure that context is consistent with placement and that we do not support longform

* updated playersize property name

* fixed size parsing to be able to handle single player size as well as several

* Changed playersize to plural playersizes in CDB contract

* Use displayurl instead of creative as we want to fetch the direct url vast cache instead a vast wrapper
* toprtbBidAdapter

* topRTB adapter hbid queryparam added

* toprtbBidAdapter-ssp aws url

* topRTBBidAdapter

* Video format topRTBBidAdapter

* Video format topRTBBidAdapter

* deviceType added

* tracking new added

* impression event added

* fix test failed

* fix testing failed

* removed debug logs

* added single quotes in adUnitId

* remove console log

* code committed to add SSL

* adunitId changes for valid response
* nanointeractive bid adapter

* nanointeractive bid adapter

* - using utils.getParameterByName instead of utils.getTopWindowLocation().href
- bidderCode is removed
- Default ALG changed to 'ihr'
- added protocol to 'cors' param

* markdown file

* enabling localhost for bid requests

* Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;

* New feature - subId

* Fixed lint errors

* Nano Interactive Bid Adapter
   New Bid params:
     - categoryName
     - name
   Getting referrer information

* Fixed documentation

* Removed unnecessary parameter from documentation

* Cleaning up documentation

* - Sending window location to server if possible

* - Lint errors fix

* Using utils.js method for sending location to server

* Removing unnecessary parameter passing

* added ConsentString to HB request

* removing unused location params in testing
* Update URI for IdentityLink integration

We have moved the URI for the Envelope API, and are currently shiming requests with the rt parameter. This will eventually be deprecated, so we want to update to the correct URI w/o the rt param.

* bump
…es.height and width (prebid#4006)

* changed resizing unit tests to return the first size dimensions in the sizes array

* added some changes
* Add Piximedia adapter

* Add piximediaBidAdapter.md

* Improve protocol of Piximedia bidder

* Add Piximedia adapter

* Fix piximediaBidAdapter_spec.js style

* Fix Piximedia adapter

* Revert "Fix Piximedia adapter"

This reverts commit 10a10d6.

* Impprove Piximedia adapter

* Remove CR at end of file

* Add test for pbsizes in Piximedia adapter
* Fix removeAdUnit

When there are multiple adUnits with the same code, only one of them gets removed. This fixes that.

* snapwich fix
* Changed isBidRequestValid to reject bid requests missing required parameters.

* Filter outstream video bid requests.

* Improved detection of different media types. Ignore all media types except instream video and banner.

* Added test to confirm behaviour with multi-format request.

* Removed unnecessary change to bid sizes.

* Removed unused imports and tests.

* Added log message for unsupported media types.
Fill in missing semicolons from TDID support update, which may be impacting TDID collection due to pb minification.  Also updating for consistency with remainder of adapter.
* Remove useless bidderCode in bid response

* send all the available sizes in the bid request

* Use the banner sizes if given

* avoid compatibility issue with old bid format
* update maintainer email

* Add TTD unified id

* Remove console.log

* Remove trailing spaces
pedrolopezmrf and others added 30 commits October 29, 2019 12:25
remove try catch on get lastLocation and comment currency on prebidServer adapter
…script

Mrf 60086/improve bids debugging script
bidcahcing filter: removed targetingSet condition
…invalid_bidder_name

fix(prebid): Avoid cookie sync with invalid bidder names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.