Addresses #4450 (Fix issues with Backport.System.Threading.Lock package) #4473
Conversation
| <PackageReference Include="Backport.System.Threading.Lock" Version="3.1.0" /> | ||
| <PackageReference Include="Backport.System.Threading.Lock" Version="3.1.4" /> | ||
| <Using Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net9.0'))" Alias="Lock" Include="System.Threading.Lock" /> | ||
| <Using Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net9.0'))" Alias="Lock" Include="Backport.System.Threading.Lock" /> |
There was a problem hiding this comment.
At this point, wouldn't it make more sense to make the Lock alias simply refer to System.Object? This is assuming that the only way the Lock type is currently being used is through the lock (...) syntax and not through any method calls. That way the external dependency can be dropped in its entirety.
There was a problem hiding this comment.
That would not allow the new locking API though. If an external dependency is an issue it can be used as the source generator instead.
There was a problem hiding this comment.
I'm assuming the primary usage is the lock (<some Lock instance>) syntax, if you conditionally make the Lock alias target either System.Threading.Lock or System.Object, you still get the performance benefits on .NET 9 for having System.Threading.Lock and you don't really have to think about it much more than that when writing code. Sure you can't use the new API, but I don't think many projects are actually using that to begin with.
There was a problem hiding this comment.
See my other comment regarding usage of the Backport package - it is only used in a couple projects, and so no other projects (including the generators) should reference the package at all right?
There was a problem hiding this comment.
Does this change mean that when people create a .NET 4.8 WinForms project, they won't need to add their own reference to the BackPort package?
I found that I had to add this superfluous reference when updating the samples.
For example, WinSortFilter
|
If I read this right, the only projects that should have a reference to All other csproj files with any mention of the package should have it removed?
|
Addresses #4450