Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds region ensureEl rename #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds region ensureEl rename #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ To begin, select a v2 change from the menu below.

- [Region’s el can now be a DOM node / DOM string selector / Jquery selector instance, just like a View’s el.](https://github.com/Puppets/marionette-changelog-detail#regions-el-can-now-be-a-dom-node--dom-string-selector--jquery-selector-instance-just-like-a-views-el)

- [Region’s ensureEl is now _ensureElement](https://github.com/Puppets/marionette-changelog-detail#regions-ensureel-is-now--ensureelement)

- [Regions now expose region.el and region.$el, just like View’s.](https://github.com/Puppets/marionette-changelog-detail#regions-now-expose-regionel-and-regionel-just-like-views)

- [Calling show on a region with the same view that is currently shown is now a noop.](https://github.com/Puppets/marionette-changelog-detail#calling-show-on-a-region-with-the-same-view-that-is-currently-shown-is-now-a-noop)
Expand Down Expand Up @@ -255,6 +257,10 @@ whereas `swap` is only changed when it goes from being occupied by one view to b
One of the great features of Views is the flexibility in specifying their `el`. But Regions never had the same flexibility, always
requiring you to pass a selector string. In v2 that has changed!

##### Region’s ensureEl is now _ensureElement

Region's `ensureEl` functioned in the exact same way that View's `_ensureElement` did. So we renamed it.

##### Regions now expose region.el and region.$el, just like View’s.

Just like Views, you can now access the Region's raw `el`. In v1 this property always remained the selector string. To access the selector
Expand Down