Skip to content

Commit

Permalink
Don't declare sample plugin transitive dependencies (jenkinsci#2470)
Browse files Browse the repository at this point in the history
Removes declarations of:

* cloudbees-folder
* favorite
* pipeline-groovy-lib
* pipeline-model-definition
* variant
* workflow-basic-steps
* workflow-durable-task-step
* workflow-multibranch

Attempting to follow the guidance from the README that says:

> Avoid adding transitive dependencies to sample-plugin/pom.xml. It
> is supposed to look as much as possible like a real plugin, and a real
> plugin should only declare its direct dependencies and not its transitive
> dependencies.
  • Loading branch information
MarkEWaite authored Sep 6, 2023
1 parent 3f87ffe commit acad2e3
Showing 1 changed file with 0 additions and 40 deletions.
40 changes: 0 additions & 40 deletions sample-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,6 @@
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>pipeline-groovy-lib</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>plugin-util-api</artifactId>
Expand Down Expand Up @@ -373,11 +368,6 @@
<artifactId>cloudbees-bitbucket-branch-source</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>cloudbees-folder</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>cloudbees-folder</artifactId>
Expand Down Expand Up @@ -699,11 +689,6 @@
<artifactId>unique-id</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>variant</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>view-job-filters</artifactId>
Expand Down Expand Up @@ -800,33 +785,18 @@
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-basic-steps</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-cps</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-durable-task-step</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-job</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-multibranch</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-multibranch</artifactId>
Expand All @@ -845,22 +815,12 @@
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkinsci.plugins</groupId>
<artifactId>pipeline-model-definition</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkinsci.plugins</groupId>
<artifactId>pipeline-model-definition</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>favorite</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
<repositories>
<repository>
Expand Down

0 comments on commit acad2e3

Please sign in to comment.