Fixed generating error on invalid lookup/optionset comparison to string

Fixes #506
MarkMpn · Jul 9, 2024 · 4c6d313 · 4c6d313
1 parent d5cf5bd
commit 4c6d313
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/MarkMpn.Sql4Cds.Engine/Ado/Sql4CdsError.cs b/MarkMpn.Sql4Cds.Engine/Ado/Sql4CdsError.cs
@@ -219,7 +219,7 @@ internal static Sql4CdsError AmbiguousColumnName(ColumnReferenceExpression colum
 
         internal static Sql4CdsError ConversionFailed(DataTypeReference sourceType, Literal sourceValue, DataTypeReference targetType)
         {
-            return Create(245, sourceValue, GetTypeName(sourceType), (SqlInt32)sourceValue.Value.Length, Collation.USEnglish.ToSqlString(sourceValue.Value), GetTypeName(targetType));
+            return Create(245, sourceValue, Collation.USEnglish.ToSqlString(GetTypeName(sourceType)), (SqlInt32)sourceValue.Value.Length, Collation.USEnglish.ToSqlString(sourceValue.Value), Collation.USEnglish.ToSqlString(GetTypeName(targetType)));
         }
 
         internal static Sql4CdsError CollationConflict(TSqlFragment fragment, Collation source, Collation target, string operationName)