Merge pull request #134 from MarkMpn/type-conversion

Type Conversion Fix
MarkMpn · Dec 1, 2021 · 9702d47 · 9702d47
2 parents 6c383d8 + c8cdd35
commit 9702d47
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/MarkMpn.Sql4Cds.Engine/ExecutionPlanBuilder.cs b/MarkMpn.Sql4Cds.Engine/ExecutionPlanBuilder.cs
@@ -422,6 +422,12 @@ attr is LookupAttributeMetadata lookupAttr &&
                         var attr = attributes[colName];
                         targetName = attr.LogicalName;
                         targetType = attr.GetAttributeSqlType();
+
+                        // If we're inserting into a lookup field, the field type will be a SqlEntityReference. Change this to
+                        // a SqlGuid so we can accept any guid values, including from TDS endpoint where SqlEntityReference
+                        // values will not be available
+                        if (targetType == typeof(SqlEntityReference))
+                            targetType = typeof(SqlGuid);
                     }
 
                     if (!schema.ContainsColumn(sourceColumns[i], out var sourceColumn))

diff --git a/MarkMpn.Sql4Cds.Engine/MarkMpn.Sql4Cds.Engine.nuspec b/MarkMpn.Sql4Cds.Engine/MarkMpn.Sql4Cds.Engine.nuspec
@@ -12,6 +12,7 @@
     <description>Convert SQL queries to FetchXml and execute them against Dataverse / D365</description>
     <summary>Convert SQL queries to FetchXml and execute them against Dataverse / D365</summary>
     <releaseNotes>Fixed decimal number handling with non-English regional settings
+Fixed "No explicit conversion exists" error when using guid string literals
     </releaseNotes>
     <copyright>Copyright © 2020 Mark Carrington</copyright>
     <language>en-GB</language>

diff --git a/MarkMpn.Sql4Cds/MarkMpn.SQL4CDS.nuspec b/MarkMpn.Sql4Cds/MarkMpn.SQL4CDS.nuspec
@@ -24,6 +24,7 @@ Using the preview TDS Endpoint, SELECT queries can also be run that aren't conve
     <summary>Convert SQL queries to FetchXML and execute them against Dataverse / D365</summary>
     <releaseNotes>Fixed decimal number handling with non-English regional settings
 Added missing comma in generated M query
+Fixed "No explicit conversion exists" error when using guid string literals
     </releaseNotes>
     <copyright>Copyright © 2019 Mark Carrington</copyright>
     <language>en-GB</language>