add post-install script for haskell #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…markus-autotesting into stack-post-install
for more information, see https://pre-commit.ci
david-yz-liu
approved these changes
Apr 20, 2024
donny-wong
approved these changes
Apr 22, 2024
pretendWhale
added a commit
to pretendWhale/markus-autotesting
that referenced
this pull request
Jul 2, 2024
* add post-install script for haskell * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update tests with stack_root * fix test_ci * remove test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * disable stack upgrade recommendation --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a post-install script to update permissions on
stackcreated files needed for worker users to run stack build/exec. Note that I also updated the resolver used as16.17is the lowest resolver compatible with ubuntu 22.04's defaultghc. I've opened an issue about making the resolver version a setting, and I think we should make a PR to make it a setting before this PR goes into release.Note: there was originally a test for this change, but because the tests do not currently install all testers, it failed. We can re-add tests in a later PR where we make tests more extensive. (part of the changes for the test involved updating
test_ci.yml. I noted that the tests were still running on ubuntu 20.04, so I updated that to 20.04. I've left that change in as it should have been in a previous PR.)