use rownames to check installed packages and ensure stringi installed… #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-yz-liu
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix two issues related to R testing:
recently we received a report of the
testthatlibrary not being installed correctly. Upon examination, it appears that checkinginstalled.packages()is sufficient, becauseinstalled.packages()also lists dependencies in some rows, which can includetestthat. So the R tester skipped installation. This is fixed by checkingrownames(installed.packages()), which returns only the names of installed packages.In production, the libraries were not installing in the expected order. This sometimes resulted in the program attempting to install
tidyversebeforestringi. But sincestringiis atidyversedependency, andstringirequires specific configuration on ubuntu 22.04, this breaks the install process. Thus we ensure that stringi is always the first package installed.