Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change file type logic #1044

Merged
merged 2 commits into from
Dec 9, 2024
Merged

change file type logic #1044

merged 2 commits into from
Dec 9, 2024

Conversation

bwook00
Copy link
Contributor

@bwook00 bwook00 commented Dec 9, 2024

close #1040

  • upgrade rc3

@bwook00 bwook00 requested a review from vkehfdl1 December 9, 2024 04:57
vkehfdl1
vkehfdl1 requested changes Dec 9, 2024
View reviewed changes
autorag/data/parse/run.py Outdated Show resolved Hide resolved
@bwook00 bwook00 requested a review from vkehfdl1 December 9, 2024 05:12
@bwook00 bwook00 enabled auto-merge (squash) December 9, 2024 05:14
vkehfdl1
vkehfdl1 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwook00 bwook00 merged commit e5e2b8b into main Dec 9, 2024
3 checks passed
@bwook00 bwook00 deleted the Feature/#1040 branch December 9, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkehfdl1 vkehfdl1 vkehfdl1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HotFix] I think the logic at the file type reduction is wrong at the parser
2 participants
@bwook00 @vkehfdl1