Skip to content

Commit

Permalink
Revert "[remkop#1421] execute method in RunAll, RunFirst and `R…
Browse files Browse the repository at this point in the history
…unLast` should not be deprecated"

This reverts commit a156204.
  • Loading branch information
MarkoMackic committed Oct 17, 2021
1 parent 201bd9d commit 4532882
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ Picocli follows [semantic versioning](http://semver.org/).
* [#1381][#1382] Bugfix: Default value of option in repeated subcommand was not applied correctly. Thanks to [sfeuerhahn](https://github.com/sfeuerhahn) for the pull request.
* [#1320][#1321] Bugfix/Enhancement: Use system properties `sun.stdout.encoding` and `sun.stderr.encoding` when creating the `PrintWriters` returned by `CommandLine::getOut` and `CommandLine::getErr`. Thanks to [Philippe Charles](https://github.com/charphi) for the investigation and the pull request.
* [#1415] Bugfix/DOC: fix NullPointerException in README Example. Thanks to [shannonbay](https://github.com/shannonbay) for raising this.
* [#1421] Bugfix/DOC: `execute` method in `RunAll`, `RunFirst` and `RunLast` should not be deprecated. Thanks to [Gamal DeWeever](https://github.com/gadeweever) for raising this.
* [#1326][#1339] DOC: Added documentation and examples for controlling the locale. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
* [#1296] DOC: add Kotlin code samples to user manual; other user manual improvements. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
* [#1299] DOC: Link to `IParameterPreprocessor` from `IParameterConsumer` javadoc. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
Expand Down
9 changes: 0 additions & 9 deletions src/main/java/picocli/CommandLine.java
Original file line number Diff line number Diff line change
Expand Up @@ -2228,9 +2228,6 @@ private int resolveExitCode(int exitCodeOnSuccess, R executionResult, List<IExit
* For use by the {@link #execute(String...) execute} method.
* @since 2.0 */
public static class RunFirst extends AbstractParseResultHandler<List<Object>> implements IParseResultHandler {
/** {@inheritDoc} */
public int execute(ParseResult parseResult) throws ExecutionException { return super.execute(parseResult); }

/** Prints help if requested, and otherwise executes the top-level {@code Runnable} or {@code Callable} command.
* Finally, either a list of result objects is returned, or the JVM is terminated if an exit code {@linkplain #andExit(int) was set}.
* If the top-level command does not implement either {@code Runnable} or {@code Callable}, an {@code ExecutionException}
Expand Down Expand Up @@ -2312,9 +2309,6 @@ protected List<IExitCodeGenerator> extractExitCodeGenerators(ParseResult parseRe
* </p>
* @since 2.0 */
public static class RunLast extends AbstractParseResultHandler<List<Object>> implements IParseResultHandler {
/** {@inheritDoc} */
public int execute(ParseResult parseResult) throws ExecutionException { return super.execute(parseResult); }

/** Prints help if requested, and otherwise executes the most specific {@code Runnable} or {@code Callable} subcommand.
* <p>For {@linkplain Command#subcommandsRepeatable() repeatable subcommands}, this method
* may execute multiple subcommands: the most deeply nested subcommands that have the same parent command.</p>
Expand Down Expand Up @@ -2387,9 +2381,6 @@ protected List<IExitCodeGenerator> extractExitCodeGenerators(ParseResult parseRe
* For use by the {@link #execute(String...) execute} method.
* @since 2.0 */
public static class RunAll extends AbstractParseResultHandler<List<Object>> implements IParseResultHandler {
/** {@inheritDoc} */
public int execute(ParseResult parseResult) throws ExecutionException { return super.execute(parseResult); }

/** Prints help if requested, and otherwise executes the top-level command and all subcommands as {@code Runnable},
* {@code Callable} or {@code Method}. Finally, either a list of result objects is returned, or the JVM is terminated if an exit
* code {@linkplain #andExit(int) was set}. If any of the {@code CommandLine} commands does not implement either
Expand Down

0 comments on commit 4532882

Please sign in to comment.