Revert "[remkop#1415] Bugfix/DOC: fix NullPointerException in README …

…Example"

This reverts commit a736548.

RELEASE-NOTES.md

@@ -33,7 +33,6 @@ Picocli follows [semantic versioning](http://semver.org/).
 * [#1331] Bugfix: Avoid `IllegalArgumentException` when parent has no standard help options and `scope = INHERIT`, while subcommand does have mixed-in standard help options. Thanks to [Andreas Deininger](https://github.com/deining) for raising this.
 * [#1381][#1382] Bugfix: Default value of option in repeated subcommand was not applied correctly. Thanks to [sfeuerhahn](https://github.com/sfeuerhahn) for the pull request.
 * [#1320][#1321] Bugfix/Enhancement: Use system properties `sun.stdout.encoding` and `sun.stderr.encoding` when creating the `PrintWriters` returned by  `CommandLine::getOut` and `CommandLine::getErr`. Thanks to [Philippe Charles](https://github.com/charphi) for the investigation and the pull request.
-* [#1415] Bugfix/DOC: fix NullPointerException in README Example. Thanks to [shannonbay](https://github.com/shannonbay) for raising this.
 * [#1326][#1339] DOC: Added documentation and examples for controlling the locale. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
 * [#1296] DOC: add Kotlin code samples to user manual; other user manual improvements. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.
 * [#1299] DOC: Link to `IParameterPreprocessor` from `IParameterConsumer` javadoc. Thanks to [Andreas Deininger](https://github.com/deining) for the pull request.

picocli-shell-jline3/README.md

@@ -143,10 +143,6 @@ public class Example {
 
         CliCommands() {}
 
-        public void setReader(LineReader reader){
-            out = reader.getTerminal().writer();
-        }
-
         public void run() {
             out.println(new CommandLine(this).getUsageMessage());
         }
@@ -254,7 +250,6 @@ public class Example {
                         .variable(LineReader.LIST_MAX, 50)   // max tab completion candidates
                         .build();
                 builtins.setLineReader(reader);
-                commands.setReader(reader);
                 factory.setTerminal(terminal);
                 TailTipWidgets widgets = new TailTipWidgets(reader, systemRegistry::commandDescription, 5, TailTipWidgets.TipType.COMPLETER);
                 widgets.enable();

picocli-shell-jline3/src/test/java/picocli/shell/jline3/example/Example.java

@@ -51,10 +51,6 @@ static class CliCommands implements Runnable {
 
         CliCommands() {}
 
-        public void setReader(LineReader reader){
-            out = reader.getTerminal().writer();
-        }
-
         public void run() {
             out.println(new CommandLine(this).getUsageMessage());
         }
@@ -162,7 +158,6 @@ public static void main(String[] args) {
                         .variable(LineReader.LIST_MAX, 50)   // max tab completion candidates
                         .build();
                 builtins.setLineReader(reader);
-                commands.setReader(reader);
                 factory.setTerminal(terminal);
                 TailTipWidgets widgets = new TailTipWidgets(reader, systemRegistry::commandDescription, 5, TailTipWidgets.TipType.COMPLETER);
                 widgets.enable();