Boolean's shouldBeTrue/shouldBeFalse extension showing incorrect error message

[criverad]

Hi all,

Running something like:

true.shouldBeFalse()

prints the following exception to the console:

null
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.junit.Assert.assertFalse(Assert.java:74)
	at org.amshove.kluent.BasicKt.shouldBeFalse(Basic.kt:28)
...

the error message is misleading (null) and it could be improved to something more descriptive.

[AndreasVolkmann]

Totally agree. Error messages are something that needs to be worked on.

[MarkusAmshove]

I agree that messages should be clearer. I thought delegating to the JUnit assertions was fine enough, but they don't seem to provide good messages all times.

I've written a prototype to get the behavior of Shoudly where if you write

val number = 5
number.shouldEqual(10)

you get the exact statement (number.shouldEqual(10)) in the failure message, but getting the source from the compiled class files isn't that reliable :-/
In .NET they seem to just have the path to the source in the PDB (debug) files.

[MarkusAmshove]

If you want you can review the change before I release it :-)

[MarkusAmshove]

I've just released these changes with v1.34