Add Assertions for BigDecimal #116
Conversation
| import java.math.BigDecimal | ||
|
|
||
| infix fun BigDecimal.shouldEqualTo(expected: BigDecimal) = | ||
| this.apply { assertTrue("Expected $this to be equal to $expected", this == expected) } |
There was a problem hiding this comment.
I don't think this is correct implementation. The whole point is to avoid using == operator on BigDecimals and use compareTo instead. Same applies for other comparison operators (<, >, >=, !=, <=). This answer on stack overflow explains this much better then I do.
There was a problem hiding this comment.
You're right, at the first glance it looked like kotlin had overloads for the oprerators
| val a = BigDecimal(1925112616126126) | ||
| val b = BigDecimal(1925112616126126) | ||
| a.shouldEqualTo(b) | ||
| } |
There was a problem hiding this comment.
Add following test and it will fail in your current implementation:
@Test
fun passWhenComparingTwoEqualValuesWithDifferentScale() {
val a = BigDecimal(BigInteger.valueOf(1), -1) // 10
val b = BigDecimal(BigInteger.valueOf(10)) // 10
a.shouldEqualTo(b)
}There was a problem hiding this comment.
Good catch, that was what I was curious about, thanks :-)
|
If you want you can review this PR now, as I've implemented the major assertions. I'm still unsure if ranges would make sense in case of |
MarkusAmshove
changed the title
Related issue: #114
This PR brings all numerical assertions from the
commonmodule to the Java typeBigInteger.shouldEqualToshouldNotEqualToshouldBeGreaterThanshouldNotBeGreaterThanshouldBeGreaterOrEqualToshouldNotBeGreaterOrEqualToshouldBeLessThanshouldNotBeLessThanshouldBeLessOrEqualToshouldNotBeLessOrEqualToshouldBePositiveshouldBeNegativeshouldBeInRange(Unclear what overloads this should have)shouldNotBeInRange(Unclear what overloads this should have)