Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent test assert name #172

Merged
merged 7 commits into from
Jan 5, 2020
Merged

Consistent test assert name #172

merged 7 commits into from
Jan 5, 2020

Conversation

JcMinarro
Copy link
Contributor

@JcMinarro JcMinarro commented Jan 3, 2020 •
edited
Loading

Description:
-. Rename shouldEqualTo to shouldBeEqualTo
-. Rename shouldNotEqualTo to shouldNotBeEqualTo
-. Rename should equal to to should be equal to -. Rename should be equal totoshould not be equal to`

Checklist

  • I've added my name to the AUTHORS file, if it wasn't already present.

Fix #96

@JcMinarro JcMinarro force-pushed the consistent-test-assert-name branch from 2b0870d to 5ee7799 Compare January 3, 2020 14:57
@MarkusAmshove MarkusAmshove mentioned this pull request Jan 5, 2020
Closed
18 tasks
@MarkusAmshove MarkusAmshove merged commit ca8bf8d into MarkusAmshove:master Jan 5, 2020
@MarkusAmshove
Copy link
Owner

This is now released with v1.59 :-)

@JcMinarro JcMinarro deleted the consistent-test-assert-name branch January 5, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should be equal inconsistency
2 participants
@JcMinarro @MarkusAmshove