org.junut4.ComparisonFailure thrown in jvm module only #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…once a complex property is compared and it's 'the same' it stopped comparing other simple properties. Improved formatting of complex nested types in Equivalency.toStructureString() and Equivalency.iterableToStructuredString() methods (caused by the bug described above).
…ion in the jvm module only - js and native use AssertionError instead. Added support of assertSoftly in Equavalency.kt.
|
Thank you for the PR, I'll have a closer look this weekend because there are a lot of changes :-) |
MarkusAmshove
approved these changes
Jul 11, 2021
|
I've looked through the changes and they all seem fine 👍 I've also tested the diff window with both Windows and Linux, works on both :-) For equality, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're really a lot of changes targeting all 3 platforms related to org.junit4.ComparisonFailure exception that is used by IntelliJ IDEA and AndriodStudio to show very useful "compare" window in case of asserts related to equals/not equals/equivalent/not equivalent.
And finally Equivalency functionality is supported with assertSoftly notation.