-
Notifications
You must be signed in to change notification settings - Fork 64
feat(build): Use java matrix in github action #222
feat(build): Use java matrix in github action #222
Conversation
I'm wondering if it's because I build the release artifacts locally with Java 17, meaning the target version doesn't get picked up correctly, although setting it in the resulting module file. I think that's an easy test that I can do locally with your earlier repro |
I think I could make you repro work locally. When building Kluent with Java 11 and publishing it locally, then I can run all tests in your project with that version and Java 11. Your matrix with JVM versions is interesting, I think we'll take that for github actions :) I'll also set up a JDK 8 build for publishing. You can test your projects locally by doing the following:
This worked for me |
Yep that worked for me too (after having disabled signing). Glad you like the java matrix and thanks for fixing the issue. |
I've found a nasty workaround, as described in #223 I'll merge this PR anyway, to give you all the credit to deserve for hunting down this issue, thank you :) |
Adds the jvm version to the github action build job.
Configured in the course of trying to work on #220.
Checklist
AUTHORS
file.