Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include python 3.12 #1

Closed
wants to merge 1 commit into from
Closed

Conversation

StephanLoor
Copy link
Contributor

I'm using Python 3.12, can we allow that in the pyproject.toml?

Copy link

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better way to address this would be to change the upper bound to <4.0. Plus, I think the implicit upper bounds on dependencies should be removed, like this:

python = ">=3.8.1,<4.0"
typer = ">=0.9.0"
rich = ">=13.7.0"
tabulate = ">=0.9.0"

More often than not, upper bounds cause more problems than they solve. See example of the Black project dropping upper bounds on dependencies.

@MarkusSagen
Copy link
Owner

Agreed! It's very annoying when having unnecessary upper bounds

@MarkusSagen
Copy link
Owner

@StephanLoor @justinmayer I think it would be better to remove the upper bounds all together and fix an issue that prevented it from being installed in certain python environments.

Thank you both for bringing these issues up and for making the project better
Interested to here also how this project is used 😄

Closing this PR in favor of that PR

@StephanLoor
Copy link
Contributor Author

Thanks a lot for the insights @justinmayer!

@MarkusSagen Thanks for working on this! I stumbled upon rejx while looking for a way to speed up the process of updating project repo's using cruft, and it sounded like a very promising tool to help us with just that. I'm looking forward to trying it out once that new PR is merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants