[BUG] Enabling Panelolu support leads to compiler errors #14812

criede · 2019-08-02T13:09:16Z

<

Description

Marlin does not compile sucessfully with LCD_I2C_PANELOLU2 support

Steps to Reproduce

git clone/git pull of 2.0.x bugfix release on Aug 2 2019
Configure Marlin for RAMPS board in the usual way. I also experienced the same error when configuring for an Archim2 board.
Enable LCD_I2C_PANELOLU2
Compile

Expected behavior: Compiler finishes with no errors

Actual behavior: I get:
In file included from sketch/src/gcode/calibrate/G28.cpp:50:0:
sketch/src/gcode/calibrate/../../lcd/ultralcd.h: In static member function 'static void MarlinUI::buzz(long int, uint16_t)':
sketch/src/gcode/calibrate/../../lcd/ultralcd.h:264:9: error: 'lcd' was not declared in this scope
lcd.buzz(duration, freq);
^
exit status 1
Fehler beim Kompilieren für das Board Arduino/Genuino Mega or Mega 2560.

Additional Information

ZIP with configuration is attached.

criede · 2019-08-02T13:16:44Z

Relation to c4bb458 ?

Ludy87 · 2019-08-02T14:27:29Z

Try this PR #14803

boelle · 2019-08-06T08:26:01Z

@criede did @Ludy87's suggestion help?

criede · 2019-08-06T14:03:46Z

Just did a
git clone https://github.com/Ludy87/Marlin.git Marlin-Ludy87
, the open it with Arduino, remove comment in front of #define LCD_I2C_PANELOLU2 and compiled it.
Result: Same error:

In file included from sketch/src/module/tool_change.cpp:78:0:
sketch/src/module/../lcd/ultralcd.h: In static member function 'static void MarlinUI::buzz(long int, uint16_t)':
sketch/src/module/../lcd/ultralcd.h:243:7: error: 'lcd' was not declared in this scope
lcd.buzz(duration, freq);
^
exit status 1
Fehler beim Kompilieren für das Board Arduino/Genuino Mega or Mega 2560.

Ludy87 · 2019-08-06T14:10:03Z

Wrong tree https://github.com/Ludy87/Marlin/tree/bf2_buzzer2

branche: bf2_buzzer2

Du musst schon, wenn dann zeitnah etwas probieren und nicht 4 Tage später, wenn der Branche gelöscht oder geändert ist.
Nutze bf2_buzzer2 und es sollte funktionieren

criede · 2019-08-06T14:12:28Z

OK, getting better.
git clone --branch bf2_buzzer2 https://github.com/Ludy87/Marlin.git Marlin-Ludy87
New error:
sketch/src/lcd/HD44780/ultralcd_HD44780.cpp: In static member function 'static void MarlinUI::update_indicators()':
sketch/src/lcd/HD44780/ultralcd_HD44780.cpp:1100:26: error: 'class Temperature' has no member named 'degTargetBed'
if (thermalManager.degTargetBed() > 0) leds |= LED_A;
^
exit status 1
Fehler beim Kompilieren für das Board Arduino/Genuino Mega or Mega 2560.

criede · 2019-08-06T14:19:18Z

#define TEMP_SENSOR_BED 1
(default is 0)
Then:

/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp:18:1: error: expected class-name before '{' token
{
^
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp: In constructor 'LcdKeypad::LcdKeypad(LcdKeypad::MCPType, uint8_t, uint8_t, uint8_t, int, int, int, int, int, int, int, bool)':
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp:63:59: error: 'IS_RECURRING' is not a member of 'Timer'
, m_keyPollTimer(new Timer(new KeyPollTimerAdapter(this), Timer::IS_RECURRING, s_defaultKeyPollTime))
^
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp: In destructor 'virtual LcdKeypad::~LcdKeypad()':
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp:113:26: error: 'class Timer' has no member named 'adapter'
delete m_keyPollTimer->adapter();
^
exit status 1
Fehler beim Kompilieren für das Board Arduino/Genuino Mega or Mega 2560.

Ludy87 · 2019-08-06T14:21:34Z

Deine Marlin Version entspricht der die im Branche ist! Nutze den Branche!

Marlin_bf2_buzzer2.zip

criede · 2019-08-06T14:46:44Z

Ich bin mir gerade nicht klar, was hier die Erwartungshaltung mir gegenüber ist. Ich habe einen Fehler gemeldet. Der Fehler ist klar und mit minimalen Aufwand nachvollziehbar. Soweit ich das einschätzen kann, wurde da beim Aufräumen was verschlimmbessert. Und das sollte derjenige, der aufgeräumt hat, problemlos wieder hinkriegen.
Aktuell verliere ich mich in Branches und bekomme immer neue Fehlermeldungen.
Ludy, tu mir einen Gefallen. Nimm den Code, aktiviere Panelolu und schau selbst was passiert.
Mir reicht mir das wissen, das dran gearbeitet wird und zu gegebener Zeit eine kurze Meldung "fixed in 2.0.x" völlig.
Danke - ich weiß Eure Arbeit zu schätzen.

Ludy87 · 2019-08-06T14:52:22Z

Schau in meine angehängte zip und du wirst DEINE Config vorfinden und ggf. den Fix, den du bitte Testen sollst beinhalten. Solange der Fix nicht bestätigt ist, wird er auch nicht veröffentlicht!

criede · 2019-08-06T15:04:35Z

Zu sagen was man will steigert die Chance zu bekommen was man will.... ;-)

extracted the ZIP, compiling it now with Arduino 1.8.9 on Linux. Error message:

/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp:18:1: error: expected class-name before '{' token
{
^
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp: In constructor 'LcdKeypad::LcdKeypad(LcdKeypad::MCPType, uint8_t, uint8_t, uint8_t, int, int, int, int, int, int, int, bool)':
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp:63:59: error: 'IS_RECURRING' is not a member of 'Timer'
, m_keyPollTimer(new Timer(new KeyPollTimerAdapter(this), Timer::IS_RECURRING, s_defaultKeyPollTime))
^
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp: In destructor 'virtual LcdKeypad::~LcdKeypad()':
/home/chr/Arduino/libraries/arduino-display-lcdkeypad/LcdKeypad.cpp:113:26: error: 'class Timer' has no member named 'adapter'
delete m_keyPollTimer->adapter();
^
exit status 1
Fehler beim Kompilieren für das Board Arduino/Genuino Mega or Mega 2560.

Ludy87 · 2019-08-06T15:07:36Z

Das ist jetzt kein Marlin Fehler mehr, scheinbar hast du die falsche lib installiert bzw. garkeine

https://github.com/lincomatic/LiquidTWI2/archive/master.zip

criede · 2019-08-06T15:14:43Z

OK, das ist was anderes. Ich geh mal suchen.

criede · 2019-08-06T15:22:43Z

ok, in arduino, you can add https://github.com/dniklaus/arduino-display-lcdkeypad from the "manage libraries" menu. That doesn't work.
Adding https://github.com/lincomatic/LiquidTWI2/archive/master.zip as ZIP archive works.
Thanks for your help!

Ludy87 · 2019-08-06T15:26:28Z

Thank you for your feedback!

Has the function been preserved or are there problems with the display?

Ludy87 · 2019-08-15T21:55:16Z

@thinkyhead, can this (https://github.com/Ludy87/Marlin/tree/bf2_buzzer2) be seen as a solution to the problem?

Here could be closed.

boelle · 2019-09-24T15:29:14Z

@criede problem fixed?

boelle · 2019-10-12T11:18:37Z

Lack of Activity
This issue is being closed due to lack of activity. If you have solved the
issue, please let us know how you solved it. If you haven't, please tell us
what else you've tried in the meantime, and possibly this issue will be
reopened.

chepo92 · 2019-11-03T16:36:22Z

@Ludy87 your fix is working for Viki 1 I2C LCD, had to make some minor additions, should PR them to your branch?

github-actions · 2020-07-04T03:03:49Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

boelle changed the title ~~Enabling Panelolu support leads to compiler errors~~ [BUG] Enabling Panelolu support leads to compiler errors Aug 5, 2019

boelle closed this as completed Oct 12, 2019

This was referenced Oct 31, 2019

[1.1.x] RAMPS + Viki1 LCD compatibility #15736

Merged

[BUG] [bugfix-2.0] Ramps and Viki LCD not compiling #15765

Closed

chepo92 mentioned this issue Nov 3, 2019

Fix for Panelolu 2 and Viki 1 LCD #15792

Closed

github-actions bot locked and limited conversation to collaborators Jul 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Enabling Panelolu support leads to compiler errors #14812

[BUG] Enabling Panelolu support leads to compiler errors #14812

criede commented Aug 2, 2019 •

edited

Loading

criede commented Aug 2, 2019

Ludy87 commented Aug 2, 2019

boelle commented Aug 6, 2019

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019 •

edited

Loading

criede commented Aug 6, 2019

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019 •

edited

Loading

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019

criede commented Aug 6, 2019 •

edited

Loading

Ludy87 commented Aug 6, 2019 •

edited

Loading

criede commented Aug 6, 2019

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019

Ludy87 commented Aug 15, 2019

boelle commented Sep 24, 2019

boelle commented Oct 12, 2019

chepo92 commented Nov 3, 2019

github-actions bot commented Jul 4, 2020

[BUG] Enabling Panelolu support leads to compiler errors #14812

[BUG] Enabling Panelolu support leads to compiler errors #14812

Comments

criede commented Aug 2, 2019 • edited Loading

Description

Steps to Reproduce

Additional Information

criede commented Aug 2, 2019

Ludy87 commented Aug 2, 2019

boelle commented Aug 6, 2019

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019 • edited Loading

criede commented Aug 6, 2019

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019 • edited Loading

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019

criede commented Aug 6, 2019 • edited Loading

Ludy87 commented Aug 6, 2019 • edited Loading

criede commented Aug 6, 2019

criede commented Aug 6, 2019

Ludy87 commented Aug 6, 2019

Ludy87 commented Aug 15, 2019

boelle commented Sep 24, 2019

boelle commented Oct 12, 2019

chepo92 commented Nov 3, 2019

github-actions bot commented Jul 4, 2020

criede commented Aug 2, 2019 •

edited

Loading

Ludy87 commented Aug 6, 2019 •

edited

Loading

Ludy87 commented Aug 6, 2019 •

edited

Loading

criede commented Aug 6, 2019 •

edited

Loading

Ludy87 commented Aug 6, 2019 •

edited

Loading